Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SlashCommandGroup description not being truly optional #1586

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

NeloBlivion
Copy link
Member

Summary

Fixes SlashCommandGroup raising a TypeError when not passing in a description.

This attribute is listed as optional in the library, but it's actually required by Discord; as such, if you pass None into it the library is meant to set it to "No description provided" for the user. However, validation came before setting it to the default value which resulted in users having to pass it in.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@Lulalaby Lulalaby enabled auto-merge (rebase) August 23, 2022 04:18
@Lulalaby Lulalaby requested a review from Dorukyum August 23, 2022 04:18
@Dorukyum Dorukyum requested review from Middledot and removed request for Dorukyum August 23, 2022 07:26
Copy link
Contributor

@baronkobama baronkobama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lulalaby Lulalaby merged commit ec1561e into Pycord-Development:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants