Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext.bridge): bridge groups failing #1633

Conversation

Middledot
Copy link
Member

Summary

Fix #1629

Bridge group commands fail because

  1. SlashCommandGroups don't have a callback parameter
  2. Cogs took the variants of the subcommands of the [bridge] group (e.g. BridgeGroup.subcommands[0].slash_variant) as regular commands which also breaks everything

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@Middledot Middledot added the bug Something isn't working label Sep 11, 2022
@Middledot Middledot changed the title fix(ext.bridge): groups fail fix(ext.bridge): bridge groups failing Sep 11, 2022
@Middledot Middledot enabled auto-merge (squash) September 11, 2022 01:59
@Middledot Middledot merged commit d2cee2a into Pycord-Development:master Sep 12, 2022
@Middledot Middledot deleted the bridge-cmds-broken-again-massive-shock branch September 15, 2022 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't create bridge group in a cog
3 participants