Remove unnecessary instance check in autocomplete #1643
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1630
The autocomplete hooks recently had typechecking applied, which would only pass if a command was specifically a
Command
. Currently, sub-commands are an instance ofSlashCommandGroup
. Because of this, the check would fail, and autocomplete Options in subcommands would fail to execute.Note that
ApplicationCommand
also encompasses Bridged commands and Context (Message/User) commands. I'm happy to update this PR to change typechecking for(Command, SlashCommandGroup)
if needed, but this is better than having subcommand autocomplete being broken.Information
Checklist
type: ignore
comments were used, a comment is also left explaining why.