Fix member.ban and TypeError in guild.ban #1666
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since
delete_message_seconds
default was changed toNone
, you run into a TypeError when it isn't passed in.As such, the default is changed back to 0. Regarding a concern raised in the original PR, if the defaults are 0 then the data won't be set anyway.
This PR also updates
Member.ban
to supportdelete_message_seconds
as it seemed to be untouched... as such, allmember.ban
calls in 2.2.0 may currently be broken.Information
Checklist
type: ignore
comments were used, a comment is also left explaining why.