Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1674 #1719

Merged
merged 1 commit into from
Oct 22, 2022
Merged

fix: #1674 #1719

merged 1 commit into from
Oct 22, 2022

Conversation

plun1331
Copy link
Member

Summary

Fixes #1674

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@plun1331 plun1331 requested a review from a team as a code owner October 22, 2022 04:58
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you're doing it right but just for my own mind:
In c# if i have an object which can be null, x.value could fail, is it not like that in python?

@Lulalaby Lulalaby enabled auto-merge (squash) October 22, 2022 05:02
@plun1331 plun1331 added the bug Something isn't working label Oct 22, 2022
@plun1331
Copy link
Member Author

I guess you're doing it right but just for my own mind: In c# if i have an object which can be null, x.value could fail, is it not like that in python?

the message flags should never be none in this scenario as they're defined like so:

flags = MessageFlags.suppress_embeds if suppress else MessageFlags.DEFAULT_VALUE

@Lulalaby Lulalaby merged commit 25d87bd into master Oct 22, 2022
@Dorukyum Dorukyum deleted the fix-1674 branch October 22, 2022 07:10
@Lulalaby
Copy link
Member

I see thx

@honzajavorek
Copy link
Contributor

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

send(suppress=True) causes TypeError: Type is not JSON serializable: flag_value
4 participants