Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: application role connections #1791

Merged
merged 41 commits into from
Feb 7, 2023
Merged

feat: application role connections #1791

merged 41 commits into from
Feb 7, 2023

Conversation

plun1331
Copy link
Member

@plun1331 plun1331 commented Nov 21, 2022 •
edited by Lulalaby
Loading

Summary

discord/discord-api-docs#5668

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@plun1331 plun1331 added feature Implements a feature priority: low Low Priority status: in progress Work in Progess upcoming discord feature Involves a feature not yet fully released by Discord labels Nov 21, 2022
@codecov
Copy link

codecov bot commented Nov 21, 2022 •
edited
Loading

Codecov Report

Merging #1791 (69fbaf2) into master (615f48d) will increase coverage by 0.05%.
The diff coverage is 53.70%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1791      +/-   ##
==========================================
+ Coverage   33.26%   33.32%   +0.05%     
==========================================
  Files          96       97       +1     
  Lines       18696    18750      +54     
==========================================
+ Hits         6220     6249      +29     
- Misses      12476    12501      +25
Flag Coverage Δ
macos-latest-3.10 33.31% <53.70%> (+0.05%) ⬆️
macos-latest-3.11 33.31% <53.70%> (+0.05%) ⬆️
macos-latest-3.8 33.32% <53.70%> (+0.05%) ⬆️
macos-latest-3.9 33.32% <53.70%> (+0.05%) ⬆️
ubuntu-latest-3.10 33.31% <53.70%> (+0.05%) ⬆️
ubuntu-latest-3.11 33.31% <53.70%> (+0.05%) ⬆️
ubuntu-latest-3.8 33.32% <53.70%> (+0.05%) ⬆️
ubuntu-latest-3.9 33.32% <53.70%> (+0.05%) ⬆️
windows-latest-3.10 33.31% <53.70%> (+0.05%) ⬆️
windows-latest-3.11 33.31% <53.70%> (+0.05%) ⬆️
windows-latest-3.8 33.32% <53.70%> (+0.05%) ⬆️
windows-latest-3.9 33.32% <53.70%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/http.py 23.05% <33.33%> (+0.07%) ⬆️
discord/client.py 28.94% <37.50%> (+0.15%) ⬆️
discord/application_role_connection.py 46.66% <46.66%> (ø)
discord/__init__.py 100.00% <100.00%> (ø)
discord/enums.py 79.93% <100.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 615f48d...69fbaf2. Read the comment docs.

Dorukyum
Dorukyum previously requested changes Nov 22, 2022
View reviewed changes
discord/application_role_connection.py Outdated Show resolved Hide resolved
discord/types/application_role_connection.py Outdated Show resolved Hide resolved
@Lulalaby @Dorukyum
Apply suggestions from code review
b3bb0a6 
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
@Lulalaby Lulalaby requested a review from Dorukyum November 22, 2022 13:58
@Lulalaby Lulalaby marked this pull request as ready for review November 22, 2022 13:58
@Lulalaby Lulalaby requested a review from a team as a code owner November 22, 2022 13:58
Lulalaby
Lulalaby previously approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate github sometimes

EmmmaTech
EmmmaTech suggested changes Nov 23, 2022
View reviewed changes
discord/application_role_connection.py Outdated Show resolved Hide resolved
discord/application_role_connection.py Outdated Show resolved Hide resolved
discord/http.py Outdated Show resolved Hide resolved
@plun1331 plun1331 self-assigned this Nov 23, 2022
@plun1331 plun1331 changed the title feat: start of application role connection feat: application role connections Nov 23, 2022
BobDotCom
BobDotCom previously requested changes Nov 30, 2022
View reviewed changes
Copy link
Member

@BobDotCom BobDotCom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry

Lulalaby
Lulalaby reviewed Jan 5, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
Lulalaby
Lulalaby previously approved these changes Jan 5, 2023
View reviewed changes
@BobDotCom
Copy link
Member

A thought: Maybe we remove "Application" from the naming to shorten it? ApplicationRoleConnectionMetadataPayload is a really long class name.

@Lulalaby
Copy link
Member

Lulalaby commented Jan 5, 2023

A thought: Maybe we remove "Application" from the naming to shorten it? ApplicationRoleConnectionMetadataPayload is a really long class name.

phew, not a fan, because it's an application role connection and not a normal role connection

@BobDotCom
Copy link
Member

Status update?

@DTheIcyDragon
Copy link

any updates on this? this feature is meanwhile rolling out to every guild

@Lulalaby
Copy link
Member

any updates on this? this feature is meanwhile rolling out to every guild

We are aware

@plun1331 plun1331 enabled auto-merge (squash) January 30, 2023 05:46
@Lulalaby Lulalaby disabled auto-merge January 30, 2023 05:47
@Lulalaby Lulalaby enabled auto-merge (squash) January 30, 2023 05:47
@Lulalaby Lulalaby disabled auto-merge February 7, 2023 13:40
@Lulalaby Lulalaby merged commit 615f91a into Pycord-Development:master Feb 7, 2023
plun1331 added a commit to davidhozic/pycord that referenced this pull request Feb 7, 2023
@plun1331 @pre-commit-ci
@Lulalaby @Dorukyum
feat: application role connections (Pycord-Development#1791)
b0493dc 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Lala Sabathil <lala@pycord.dev>
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
plun1331 added a commit to davidhozic/pycord that referenced this pull request Feb 7, 2023
@plun1331
feat: application role connections (Pycord-Development#1791)
bd934e9
plun1331 added a commit to davidhozic/pycord that referenced this pull request Feb 7, 2023
@plun1331 @pre-commit-ci
@Lulalaby @Dorukyum
feat: application role connections (Pycord-Development#1791)
2385ef2 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Lala Sabathil <lala@pycord.dev>
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
plun1331 added a commit to davidhozic/pycord that referenced this pull request Feb 7, 2023
@plun1331 @pre-commit-ci
@Lulalaby @Dorukyum
feat: application role connections (Pycord-Development#1791)
17fcf23 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Lala Sabathil <lala@pycord.dev>
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustaSqu1d JustaSqu1d JustaSqu1d left review comments

@EmmmaTech EmmmaTech EmmmaTech requested changes

@ChickenDevs ChickenDevs ChickenDevs approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

@Nzii3 Nzii3 Nzii3 left review comments

@Dorukyum Dorukyum Awaiting requested review from Dorukyum

@BobDotCom BobDotCom Awaiting requested review from BobDotCom

@Middledot Middledot Awaiting requested review from Middledot

Assignees

@plun1331 plun1331

Labels
feature Implements a feature priority: low Low Priority status: awaiting review Awaiting review from a maintainer upcoming discord feature Involves a feature not yet fully released by Discord
Projects
Pycord Releases
Status: Done
Milestone
v2.4
Development

Successfully merging this pull request may close these issues.
9 participants
@plun1331 @Lulalaby @BobDotCom @DTheIcyDragon @EmmmaTech @Dorukyum @ChickenDevs @JustaSqu1d @Nzii3