Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext.bridge): fix bridge_commands attribute #1802

Merged
merged 2 commits into from
Nov 27, 2022

Conversation

Middledot
Copy link
Member

Summary

Fix #1800
Tested with the code given there

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@Middledot Middledot added bug Something isn't working ext.bridge Relating to ext.bridge labels Nov 26, 2022
@Middledot Middledot requested review from a team as code owners November 26, 2022 19:03
@codecov
Copy link

codecov bot commented Nov 26, 2022

Codecov Report

Merging #1802 (860d0b1) into master (b20f134) will decrease coverage by 0.00%.
The diff coverage is 28.57%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1802      +/-   ##
==========================================
- Coverage   33.21%   33.21%   -0.01%     
==========================================
  Files          96       96              
  Lines       18653    18657       +4     
==========================================
  Hits         6196     6196              
- Misses      12457    12461       +4     
Flag Coverage Δ
macos-latest-3.10 33.19% <28.57%> (-0.01%) ⬇️
macos-latest-3.11 33.19% <28.57%> (-0.01%) ⬇️
macos-latest-3.8 33.20% <28.57%> (-0.01%) ⬇️
macos-latest-3.9 33.20% <28.57%> (-0.01%) ⬇️
ubuntu-latest-3.10 33.19% <28.57%> (-0.01%) ⬇️
ubuntu-latest-3.11 33.19% <28.57%> (-0.01%) ⬇️
ubuntu-latest-3.8 33.20% <28.57%> (-0.01%) ⬇️
ubuntu-latest-3.9 33.20% <28.57%> (-0.01%) ⬇️
windows-latest-3.10 33.19% <28.57%> (-0.01%) ⬇️
windows-latest-3.11 33.19% <28.57%> (-0.01%) ⬇️
windows-latest-3.8 33.20% <28.57%> (-0.01%) ⬇️
windows-latest-3.9 33.20% <28.57%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/cog.py 34.92% <28.57%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b20f134...860d0b1. Read the comment docs.

@Lulalaby Lulalaby enabled auto-merge (squash) November 26, 2022 19:27
@BobDotCom BobDotCom disabled auto-merge November 27, 2022 19:36
@BobDotCom BobDotCom merged commit 36d5a7f into Pycord-Development:master Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ext.bridge Relating to ext.bridge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'AutoShardedBot' object has no attribute '_bridge_commands'.
4 participants