Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing message types #1852

Merged
merged 12 commits into from
Jan 5, 2023
Merged

feat: add missing message types #1852

merged 12 commits into from
Jan 5, 2023

Conversation

JustaSqu1d
Copy link
Member

@JustaSqu1d JustaSqu1d commented Jan 4, 2023

Summary

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@JustaSqu1d JustaSqu1d requested a review from a team as a code owner January 4, 2023 00:38
@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Merging #1852 (771d751) into master (b612eb0) will increase coverage by 0.02%.
The diff coverage is 80.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1852      +/-   ##
==========================================
+ Coverage   33.19%   33.21%   +0.02%     
==========================================
  Files          96       96              
  Lines       18670    18680      +10     
==========================================
+ Hits         6197     6205       +8     
- Misses      12473    12475       +2     
Flag Coverage Δ
macos-latest-3.10 33.20% <80.00%> (+0.02%) ⬆️
macos-latest-3.11 33.20% <80.00%> (+0.02%) ⬆️
macos-latest-3.8 33.21% <80.00%> (+0.02%) ⬆️
macos-latest-3.9 33.21% <80.00%> (+0.02%) ⬆️
ubuntu-latest-3.10 33.20% <80.00%> (+0.02%) ⬆️
ubuntu-latest-3.11 33.20% <80.00%> (+0.02%) ⬆️
ubuntu-latest-3.8 33.21% <80.00%> (+0.02%) ⬆️
ubuntu-latest-3.9 33.21% <80.00%> (+0.02%) ⬆️
windows-latest-3.10 33.20% <80.00%> (+0.02%) ⬆️
windows-latest-3.11 33.20% <80.00%> (+0.02%) ⬆️
windows-latest-3.8 33.21% <80.00%> (+0.02%) ⬆️
windows-latest-3.9 33.21% <80.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/guild.py 23.77% <0.00%> (-0.06%) ⬇️
discord/http.py 22.98% <ø> (ø)
discord/enums.py 79.06% <100.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b00b3da...771d751. Read the comment docs.

@JustaSqu1d
Copy link
Member Author

Should I add a change-log entry?

@Lulalaby
Copy link
Member

Lulalaby commented Jan 4, 2023

You can add discord/discord-api-docs#5815 and add a changelog for all :p

@JustaSqu1d JustaSqu1d changed the title feat: add role-subscription purchase enum feat: add missing message types Jan 4, 2023
@JustaSqu1d JustaSqu1d marked this pull request as draft January 4, 2023 23:53
@JustaSqu1d JustaSqu1d marked this pull request as ready for review January 5, 2023 17:17
CHANGELOG.md Outdated Show resolved Hide resolved
Lulalaby and others added 2 commits January 5, 2023 18:20
Co-authored-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com>
docs/api/enums.rst Outdated Show resolved Hide resolved
Co-authored-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com>
@Lulalaby Lulalaby enabled auto-merge (squash) January 5, 2023 17:22
Lulalaby
Lulalaby previously approved these changes Jan 5, 2023
auto-merge was automatically disabled January 5, 2023 17:23

Head branch was pushed to by a user without write access

@Lulalaby Lulalaby enabled auto-merge (squash) January 5, 2023 17:24
@Lulalaby Lulalaby requested a review from BobDotCom January 5, 2023 17:24
@BobDotCom BobDotCom requested a review from ChickenDevs January 5, 2023 17:29
@Lulalaby Lulalaby merged commit a9e9ae0 into Pycord-Development:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants