Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change Colour.embed_background() colors to correspond to new colors #1931

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

TheGiga
Copy link
Contributor

@TheGiga TheGiga commented Feb 18, 2023

Summary

Apprently, in recent update, discord slightly changed big portion of colour scheme, including Embed and Channel backgrounds.
Changed values in discord.Colour.embed_background() to represent these changes.

This "line" should be the same colour as embed background, but it isn't.
зображення

Colour changes:
зображення

light theme was also changed, i included new colour aswell

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

Signed-off-by: gigabit- <49173264+TheGiga@users.noreply.github.com>
@TheGiga TheGiga requested a review from a team as a code owner February 18, 2023 16:11
@TheGiga TheGiga changed the title discord moment changed discord.Colour.embed_background() colours to correspond discord Feb 18, 2023
@plun1331 plun1331 changed the title changed discord.Colour.embed_background() colours to correspond discord fix: change Colour.embed_background() colors to correspond to new colors Feb 18, 2023
@Lulalaby Lulalaby enabled auto-merge (squash) February 19, 2023 02:03
@Lulalaby Lulalaby requested a review from plun1331 February 19, 2023 02:05
@Lulalaby Lulalaby merged commit 557c0d0 into Pycord-Development:master Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants