fix: pass reason to the correct method in AutoModRule
#1960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Om <92863779+Om1609@users.noreply.github.com>
OmLanke
changed the title
reason from being passed to AutoModRulereason from being passed to AutoModRule
JustaSqu1d
added
status: awaiting review
plun1331
requested changes
Mar 6, 2023
|
Please make a changelog entry as well |
Co-authored-by: plun1331 <49261529+plun1331@users.noreply.github.com> Signed-off-by: Om <92863779+Om1609@users.noreply.github.com>
for more information, see https://pre-commit.ci
Signed-off-by: Om <92863779+Om1609@users.noreply.github.com>
plun1331
changed the title
reason from being passed to AutoModRulereason to the correct method in AutoModRule
plun1331
previously approved these changes
Mar 7, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1960 +/- ##
=======================================
Coverage 33.32% 33.32%
=======================================
Files 97 97
Lines 18901 18901
=======================================
Hits 6298 6298
Misses 12603 12603
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
BobDotCom
requested changes
Mar 9, 2023
Signed-off-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com>
BobDotCom
approved these changes
Mar 9, 2023
plun1331
approved these changes
Mar 9, 2023
Lulalaby
approved these changes
Mar 9, 2023
BobDotCom
added a commit
that referenced
this pull request
Mar 20, 2023
* Remove `reason` from being passed to AutoModRule Signed-off-by: Om <92863779+Om1609@users.noreply.github.com> * Update discord/guild.py Co-authored-by: plun1331 <49261529+plun1331@users.noreply.github.com> Signed-off-by: Om <92863779+Om1609@users.noreply.github.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update CHANGELOG.md Signed-off-by: Om <92863779+Om1609@users.noreply.github.com> * Update CHANGELOG.md Signed-off-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com> --------- Signed-off-by: Om <92863779+Om1609@users.noreply.github.com> Signed-off-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com> Co-authored-by: plun1331 <49261529+plun1331@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
AutoModRuledoes not accept areasonparameter. This raises an unexpected keyword argument error.This PR fixes it.
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.