Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: webhook message editing on forums missing thread_id #1981

Merged
merged 8 commits into from
Apr 18, 2023

Conversation

qoft
Copy link
Contributor

@qoft qoft commented Mar 22, 2023

Summary

Fix editing a webhook message if the thread is a forum post or if the thread is a private thread (no starter message)

Issue here

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
  • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@qoft qoft requested a review from a team as a code owner March 22, 2023 13:41
@JustaSqu1d JustaSqu1d added priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer API Reflection Discords API wasn't correctly reflected in the lib changelog needed bug Something isn't working labels Mar 22, 2023
@Lulalaby Lulalaby linked an issue Mar 22, 2023 that may be closed by this pull request
3 tasks
@Lulalaby Lulalaby changed the title Fixed webhook message editing on forums. fix: webhook message editing on forums missing thread_id Mar 22, 2023
@Lulalaby Lulalaby enabled auto-merge (squash) March 22, 2023 19:56
@Lulalaby Lulalaby requested a review from BobDotCom March 22, 2023 19:56
discord/webhook/async_.py Show resolved Hide resolved
@Lulalaby Lulalaby disabled auto-merge March 22, 2023 19:57
@codecov
Copy link

codecov bot commented Mar 26, 2023

Codecov Report

Merging #1981 (1bde4f9) into master (72f8966) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1981      +/-   ##
==========================================
- Coverage   33.31%   33.30%   -0.01%     
==========================================
  Files          97       97              
  Lines       18933    18935       +2     
==========================================
  Hits         6307     6307              
- Misses      12626    12628       +2     
Flag Coverage Δ
macos-latest-3.10 33.29% <33.33%> (-0.01%) ⬇️
macos-latest-3.11 33.29% <33.33%> (-0.01%) ⬇️
macos-latest-3.8 33.30% <33.33%> (-0.01%) ⬇️
macos-latest-3.9 33.30% <33.33%> (-0.01%) ⬇️
ubuntu-latest-3.10 33.29% <33.33%> (-0.01%) ⬇️
ubuntu-latest-3.11 33.29% <33.33%> (-0.01%) ⬇️
ubuntu-latest-3.8 33.30% <33.33%> (-0.01%) ⬇️
ubuntu-latest-3.9 33.30% <33.33%> (-0.01%) ⬇️
windows-latest-3.10 33.29% <33.33%> (-0.01%) ⬇️
windows-latest-3.11 33.29% <33.33%> (-0.01%) ⬇️
windows-latest-3.8 33.30% <33.33%> (-0.01%) ⬇️
windows-latest-3.9 33.30% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/webhook/async_.py 23.16% <33.33%> (-0.09%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72f8966...1bde4f9. Read the comment docs.

@qoft
Copy link
Contributor Author

qoft commented Mar 26, 2023

Changes done

@qoft
Copy link
Contributor Author

qoft commented Apr 2, 2023

bump

@Lulalaby
Copy link
Member

Lulalaby commented Apr 2, 2023

bump deez nuts

@Lulalaby Lulalaby self-requested a review April 2, 2023 23:29
@qoft
Copy link
Contributor Author

qoft commented Apr 2, 2023

changes were done already ☝😲

@Lulalaby
Copy link
Member

Lulalaby commented Apr 3, 2023

We check through prs if we have time.
No need to bump anything.

Copy link
Member

@plun1331 plun1331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry.

@Lulalaby
Copy link
Member

@qoft please address the requested changes

Signed-off-by: Lala Sabathil <lala@pycord.dev>
Lulalaby
Lulalaby previously approved these changes Apr 18, 2023
@Lulalaby Lulalaby requested a review from plun1331 April 18, 2023 19:07
@Lulalaby Lulalaby merged commit 0407f28 into Pycord-Development:master Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Reflection Discords API wasn't correctly reflected in the lib bug Something isn't working changelog needed priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

discord.WebhookMessage.edit() is not handled well in Forum Channels
5 participants