Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: store message in view when sent using webhook or when message is edited #1997

Merged
merged 12 commits into from
Apr 18, 2023

Conversation

OmLanke
Copy link
Contributor

@OmLanke OmLanke commented Apr 2, 2023

Summary

Stores the message object on the view sent using webhook if the message has a view.
Fixes #1600. Also fixes #1572

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

Signed-off-by: Om <92863779+Om1609@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Apr 2, 2023

Codecov Report

Merging #1997 (9fe9a3a) into master (8a913c3) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1997      +/-   ##
==========================================
- Coverage   33.32%   33.31%   -0.02%     
==========================================
  Files          97       97              
  Lines       18927    18933       +6     
==========================================
  Hits         6307     6307              
- Misses      12620    12626       +6     
Flag Coverage Δ
macos-latest-3.10 33.29% <0.00%> (-0.02%) ⬇️
macos-latest-3.11 33.29% <0.00%> (-0.02%) ⬇️
macos-latest-3.8 33.30% <0.00%> (-0.02%) ⬇️
macos-latest-3.9 33.30% <0.00%> (-0.02%) ⬇️
ubuntu-latest-3.10 33.29% <0.00%> (-0.02%) ⬇️
ubuntu-latest-3.11 33.29% <0.00%> (-0.02%) ⬇️
ubuntu-latest-3.8 33.30% <0.00%> (-0.02%) ⬇️
ubuntu-latest-3.9 33.30% <0.00%> (-0.02%) ⬇️
windows-latest-3.10 33.29% <0.00%> (-0.02%) ⬇️
windows-latest-3.11 33.29% <0.00%> (-0.02%) ⬇️
windows-latest-3.8 33.30% <0.00%> (-0.02%) ⬇️
windows-latest-3.9 33.30% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/interactions.py 20.27% <0.00%> (-0.12%) ⬇️
discord/message.py 24.87% <0.00%> (-0.09%) ⬇️
discord/webhook/async_.py 23.25% <0.00%> (-0.10%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a913c3...9fe9a3a. Read the comment docs.

Lulalaby
Lulalaby previously approved these changes Apr 2, 2023
Signed-off-by: Om <92863779+Om1609@users.noreply.github.com>
@OmLanke OmLanke marked this pull request as ready for review April 2, 2023 19:52
@OmLanke OmLanke requested a review from a team as a code owner April 2, 2023 19:52
@OmLanke OmLanke requested a review from Lulalaby April 2, 2023 19:53
@OmLanke OmLanke changed the title fix: store message in view when sent using webhook fix: store message in view when sent using webhook or when message is edited Apr 2, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
@plun1331 plun1331 added bug Something isn't working status: awaiting review Awaiting review from a maintainer labels Apr 3, 2023
Co-authored-by: plun1331 <49261529+plun1331@users.noreply.github.com>
Signed-off-by: Om <92863779+Om1609@users.noreply.github.com>
@Lulalaby
Copy link
Member

Lulalaby commented Apr 3, 2023

@Om1609 conflicts

Signed-off-by: Om <92863779+Om1609@users.noreply.github.com>
@OmLanke
Copy link
Contributor Author

OmLanke commented Apr 3, 2023

@Om1609 conflicts

Resolved

Lulalaby and others added 3 commits April 3, 2023 18:25
@OmLanke OmLanke requested a review from plun1331 April 13, 2023 18:29
@OmLanke
Copy link
Contributor Author

OmLanke commented Apr 13, 2023

@pycord-development/core-developers pending review

@JustaSqu1d JustaSqu1d added the priority: medium Medium Priority label Apr 14, 2023
@plun1331 plun1331 requested a review from a team April 17, 2023 15:39
@Lulalaby Lulalaby enabled auto-merge (squash) April 17, 2023 18:00
@Lulalaby Lulalaby requested a review from BobDotCom April 17, 2023 18:01
@plun1331 plun1331 removed their request for review April 17, 2023 20:12
@Lulalaby Lulalaby disabled auto-merge April 18, 2023 01:42
@Lulalaby Lulalaby requested a review from JustaSqu1d April 18, 2023 03:56
@JustaSqu1d JustaSqu1d enabled auto-merge (squash) April 18, 2023 04:03
@Lulalaby Lulalaby disabled auto-merge April 18, 2023 04:04
@Lulalaby Lulalaby merged commit ceff3a4 into Pycord-Development:master Apr 18, 2023
@OmLanke OmLanke deleted the patch-5 branch April 24, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
4 participants