-
-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Received Interactions come with a channel object #2025
feat: Received Interactions come with a channel object #2025
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2025 +/- ##
=======================================
Coverage 33.29% 33.30%
=======================================
Files 97 97
Lines 18973 18965 -8
=======================================
- Hits 6317 6316 -1
+ Misses 12656 12649 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog
Summary
All interactions now come with a partial
channel
object over the gateway as per discord/discord-api-docs#6051channel
to a regular attribute instead of a cached slot, though i've currently left the previous property in.DMChannel.recipients
has been adjusted to support said attribute being missing from gateway eventsThis PR is functionally done, however I'm not entirely sure if this is a good implementation; I think there's merit in using the received channel object, but would it be better to continue using cache? Should we implement additional methods here?
Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.