Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update thread applied tags #2146

Merged
merged 3 commits into from
Jun 24, 2023

Conversation

Dorukyum
Copy link
Member

@Dorukyum Dorukyum commented Jun 24, 2023

Summary

Fixes #1870.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Dorukyum Dorukyum added the priority: high High Priority label Jun 24, 2023
@Dorukyum Dorukyum requested a review from a team as a code owner June 24, 2023 17:22
@Dorukyum Dorukyum self-assigned this Jun 24, 2023
@pullapprove4 pullapprove4 bot requested a review from Lulalaby June 24, 2023 17:22
@pullapprove4 pullapprove4 bot requested a review from Middledot June 24, 2023 17:22
@codecov
Copy link

codecov bot commented Jun 24, 2023

Codecov Report

Merging #2146 (a25b73a) into master (b076bd3) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2146      +/-   ##
==========================================
- Coverage   33.86%   33.86%   -0.01%     
==========================================
  Files         109      109              
  Lines       22360    22361       +1     
==========================================
  Hits         7573     7573              
- Misses      14787    14788       +1     
Flag Coverage Δ
macos-latest-3.10 33.84% <0.00%> (-0.01%) ⬇️
macos-latest-3.11 33.84% <0.00%> (-0.01%) ⬇️
macos-latest-3.8 33.85% <0.00%> (-0.01%) ⬇️
macos-latest-3.9 33.85% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.10 33.84% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.11 33.84% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.8 33.85% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.9 33.85% <0.00%> (-0.01%) ⬇️
windows-latest-3.10 33.84% <0.00%> (-0.01%) ⬇️
windows-latest-3.11 33.84% <0.00%> (-0.01%) ⬇️
windows-latest-3.8 33.85% <0.00%> (-0.01%) ⬇️
windows-latest-3.9 33.85% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/threads.py 30.04% <0.00%> (-0.14%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b076bd3...a25b73a. Read the comment docs.

@Dorukyum Dorukyum added bug Something isn't working status: awaiting review Awaiting review from a maintainer labels Jun 24, 2023
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol how did we missed that

@Lulalaby Lulalaby enabled auto-merge (squash) June 24, 2023 19:08
@Lulalaby Lulalaby merged commit c5345d8 into Pycord-Development:master Jun 24, 2023
@Dorukyum Dorukyum deleted the update-tags branch June 24, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: high High Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

applied_tags does not update when tags are changed on forum posts
2 participants