Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Guild.delete_auto_moderation_rule #2153

Merged
merged 21 commits into from
Aug 29, 2023

Conversation

llamaair
Copy link
Contributor

@llamaair llamaair commented Jun 27, 2023

Summary

Add a function to delete auto moderation rules either by name or id.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@JustaSqu1d JustaSqu1d added feature Implements a feature API Reflection Discords API wasn't correctly reflected in the lib changelog needed labels Jun 27, 2023
@llamaair llamaair changed the title Add delete_auto_moderation_rule feat: Add delete_auto_moderation_rule Jun 27, 2023
discord/guild.py Outdated Show resolved Hide resolved
llamaair and others added 2 commits June 27, 2023 15:06
Co-authored-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com>
Signed-off-by: Marc13 <83296140+llamaair@users.noreply.github.com>
Copy link
Member

@NeloBlivion NeloBlivion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nowhere else in the library do we include a name kwarg for deletions (roles, emojis, guilds, channels etc.)... it shouldn't be included here either.
(We also already have AutoModRule.delete(), but having a method on guild is understandable to avoid an extra fetch.)

@llamaair
Copy link
Contributor Author

llamaair commented Jun 28, 2023

Nowhere else in the library do we include a name kwarg for deletions (roles, emojis, guilds, channels etc.)... it shouldn't be included here either.

Ok, I'l remove the name kwarg 👍

@Lulalaby Lulalaby enabled auto-merge (squash) July 4, 2023 16:41
@Lulalaby Lulalaby disabled auto-merge July 4, 2023 16:41
discord/guild.py Outdated Show resolved Hide resolved
discord/guild.py Outdated Show resolved Hide resolved
discord/guild.py Outdated Show resolved Hide resolved
discord/guild.py Outdated Show resolved Hide resolved
discord/guild.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
discord/guild.py Outdated Show resolved Hide resolved
discord/guild.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@JustaSqu1d JustaSqu1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add AutoModRule.delete() as well?

Never mind that already exists

auto-merge was automatically disabled July 13, 2023 17:04

Head branch was pushed to by a user without write access

@llamaair llamaair requested review from JustaSqu1d and plun1331 July 27, 2023 14:42
@llamaair llamaair changed the title feat: Add delete_auto_moderation_rule feat: Add Guild.delete_auto_moderation_rule Jul 27, 2023
llamaair and others added 2 commits August 13, 2023 14:54
@Lulalaby Lulalaby enabled auto-merge (squash) August 29, 2023 01:32
@Lulalaby Lulalaby merged commit a3bd2a0 into Pycord-Development:master Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Reflection Discords API wasn't correctly reflected in the lib feature Implements a feature on hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants