Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: _bytes_to_base64_data not defined #2185

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

llamaair
Copy link
Contributor

@llamaair llamaair commented Jul 27, 2023

Summary

in Guild.create_role, _bytes_to_base64_data is not defined or imported as it is in other lines of the file. Modify it to be utils._bytes_to_base64_data instead.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@llamaair llamaair requested a review from a team as a code owner July 27, 2023 16:02
@pullapprove4
Copy link

pullapprove4 bot commented Jul 27, 2023

Please add a changelog entry

@llamaair llamaair changed the title fix: _bytes_to_base64_data isn't defined fix: _bytes_to_base64_data not defined Jul 27, 2023
@pullapprove4 pullapprove4 bot requested a review from Dorukyum July 27, 2023 16:25
@pullapprove4
Copy link

pullapprove4 bot commented Jul 27, 2023

Changelog requirements met

@pullapprove4
Copy link

pullapprove4 bot commented Aug 2, 2023

Please add a changelog entry

@pullapprove4
Copy link

pullapprove4 bot commented Aug 2, 2023

Changelog requirements met

Middledot
Middledot previously approved these changes Sep 17, 2023
Signed-off-by: Middledot <78228142+Middledot@users.noreply.github.com>
@Lulalaby Lulalaby enabled auto-merge (squash) October 30, 2023 17:37
@Lulalaby Lulalaby merged commit bbb1e32 into Pycord-Development:master Oct 30, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants