-
-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: VoiceClient.play wait_finish parameter for awaiting end of stream #2194
Merged
Lulalaby
merged 9 commits into
Pycord-Development:master
from
davidhozic:feat/wait_for_audio
Aug 13, 2023
Merged
feat: VoiceClient.play wait_finish parameter for awaiting end of stream #2194
Lulalaby
merged 9 commits into
Pycord-Development:master
from
davidhozic:feat/wait_for_audio
Aug 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhozic
changed the title
feat: wait_end method to VoiceClient for awaiting audio to stop playing
feat: VoiceClient.wait_end(timeout) method for waiting on audio to stop playing
Aug 3, 2023
davidhozic
changed the title
feat: VoiceClient.wait_end(timeout) method for waiting on audio to stop playing
feat: VoiceClient.wait_end method for waiting on audio to stop playing
Aug 3, 2023
davidhozic
changed the title
feat: VoiceClient.wait_end method for waiting on audio to stop playing
feat: VoiceClien wait_finish parameter for awaiting audio end
Aug 3, 2023
davidhozic
changed the title
feat: VoiceClien wait_finish parameter for awaiting audio end
feat: VoiceClient wait_finish parameter for awaiting audio end
Aug 3, 2023
davidhozic
changed the title
feat: VoiceClient wait_finish parameter for awaiting audio end
feat: VoiceClient.play wait_finish parameter for awaiting audio end
Aug 3, 2023
…ycord into feat/wait_for_audio
davidhozic
changed the title
feat: VoiceClient.play wait_finish parameter for awaiting audio end
feat: VoiceClient.play wait_finish parameter for awaiting end of stream
Aug 3, 2023
Middledot
approved these changes
Aug 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, could be useful
Lulalaby
approved these changes
Aug 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added
wait_finish
parameter toVoiceClient.play
, which will return an awaitable ifTrue
, that can be used to wait for the audio to stop playing. If set toFalse
(default), the function will not block andNone
will be returnedExample:
Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.