fix: ffmpeg terminated prematurely #2240
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See issue #2205
When streaming audio from a pipe the ffmpeg process would be terminated immediately
if there was no data left to read from the pipe. This lead to some of the audio being cut off before being fully processed by ffmpeg
This PR closes the ffmpeg process stdin instead and lets ffmpeg close itself gracefully
Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.