Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ffmpeg terminated prematurely #2240

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

ffrejaa
Copy link
Contributor

@ffrejaa ffrejaa commented Oct 9, 2023

Summary

See issue #2205

When streaming audio from a pipe the ffmpeg process would be terminated immediately
if there was no data left to read from the pipe. This lead to some of the audio being cut off before being fully processed by ffmpeg

This PR closes the ffmpeg process stdin instead and lets ffmpeg close itself gracefully

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

When streaming audio from a pipe
ffmpeg is no longer terminated prematurely
which caused audio to cut out
@Dorukyum Dorukyum enabled auto-merge (squash) November 21, 2023 05:47
@Dorukyum Dorukyum merged commit 80efff0 into Pycord-Development:master Nov 21, 2023
26 checks passed
@ffrejaa ffrejaa deleted the fix-audio-pipe branch November 21, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants