Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement monetization #2273

Merged
merged 23 commits into from
Feb 1, 2024
Merged

feat: implement monetization #2273

merged 23 commits into from
Feb 1, 2024

Conversation

plun1331
Copy link
Member

@plun1331 plun1331 commented Dec 1, 2023 •
edited
Loading

Summary

Implements monetization as documented under https://discord.com/developers/docs/monetization

I have no way of testing this as I do not have a monetization-enabled bot (and cannot make one).

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@plun1331 plun1331 requested a review from a team as a code owner December 1, 2023 21:56
@Lulalaby Lulalaby self-requested a review December 1, 2023 21:57
@Lulalaby Lulalaby self-assigned this Dec 1, 2023
@plun1331 plun1331 linked an issue Dec 1, 2023 that may be closed by this pull request
Implement App Subscription #2234
Closed
@plun1331 plun1331 added priority: low Low Priority status: awaiting review Awaiting review from a maintainer feature Implements a feature labels Dec 2, 2023
@Lulalaby Lulalaby marked this pull request as draft December 4, 2023 15:39
Lulalaby
Lulalaby requested changes Feb 1, 2024
View reviewed changes
discord/enums.py Show resolved Hide resolved
discord/guild.py Outdated Show resolved Hide resolved
discord/monetization.py Show resolved Hide resolved
discord/user.py Show resolved Hide resolved
@Lulalaby
Copy link
Member

Lulalaby commented Feb 1, 2024

  • merge conflicts

@plun1331 plun1331 requested a review from Lulalaby February 1, 2024 01:00
@plun1331 plun1331 added this to the v2.5 milestone Feb 1, 2024
Lulalaby
Lulalaby previously approved these changes Feb 1, 2024
View reviewed changes
@Lulalaby Lulalaby marked this pull request as ready for review February 1, 2024 01:01
@Lulalaby
Copy link
Member

Lulalaby commented Feb 1, 2024

image

@plun1331 plun1331 requested a review from Lulalaby February 1, 2024 01:04
@Lulalaby Lulalaby enabled auto-merge (squash) February 1, 2024 01:05
@Lulalaby Lulalaby merged commit 98d6018 into Pycord-Development:master Feb 1, 2024
29 checks passed
OmLanke pushed a commit to OmLanke/pycord that referenced this pull request Feb 9, 2024
@plun1331 @pre-commit-ci @OmLanke
feat: implement monetization (Pycord-Development#2273)
7f165b4 
Signed-off-by: plun1331 <plun1331@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nzii3 Nzii3 Nzii3 approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

Assignees

@Lulalaby Lulalaby

@plun1331 plun1331

Labels
feature Implements a feature priority: low Low Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
v2.5
Development

Successfully merging this pull request may close these issues.

Implement App Subscription
3 participants
@plun1331 @Lulalaby @Nzii3