-
-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pages): default buttons reappearing on page change #2319
fix(pages): default buttons reappearing on page change #2319
Conversation
I still need to fix one issue. When default buttons are removed they cannot be added back. Should this go in the same PR? |
You may fix it in this pr if the cause of that issue is related to the one already fixed, otherwise a new pr should be preferred. |
In the end it ended up being fine. The docs state that the user must explicitly define all arguments for page groups. Page groups args do not default to the main paginator args. This is stated in the docs. |
In that case, this pull request is complete, right? |
Yes |
Summary
Fixes
use_default_buttons
being ignored when updating a paginator.Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.