Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pages): default buttons reappearing on page change #2319

Merged
merged 5 commits into from
Jan 24, 2024
Merged

fix(pages): default buttons reappearing on page change #2319

merged 5 commits into from
Jan 24, 2024

Conversation

Icebluewolf
Copy link
Contributor

Summary

Fixes use_default_buttons being ignored when updating a paginator.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

CHANGELOG.md Outdated Show resolved Hide resolved
@Dorukyum Dorukyum changed the title fix(pages): Stop Default Buttons Reappearing On Page Change fix(pages): default buttons reappearing on page change Jan 18, 2024
@Icebluewolf Icebluewolf marked this pull request as draft January 23, 2024 13:30
@Icebluewolf
Copy link
Contributor Author

I still need to fix one issue. When default buttons are removed they cannot be added back. Should this go in the same PR?

@Dorukyum
Copy link
Member

I still need to fix one issue. When default buttons are removed they cannot be added back. Should this go in the same PR?

You may fix it in this pr if the cause of that issue is related to the one already fixed, otherwise a new pr should be preferred.

@Icebluewolf
Copy link
Contributor Author

In the end it ended up being fine. The docs state that the user must explicitly define all arguments for page groups. Page groups args do not default to the main paginator args. This is stated in the docs.

@Dorukyum
Copy link
Member

In the end it ended up being fine. The docs state that the user must explicitly define all arguments for page groups. Page groups args do not default to the main paginator args. This is stated in the docs.

In that case, this pull request is complete, right?

@Icebluewolf
Copy link
Contributor Author

Yes

@Dorukyum Dorukyum enabled auto-merge (squash) January 24, 2024 16:31
@Dorukyum Dorukyum merged commit 2f3084e into Pycord-Development:master Jan 24, 2024
29 checks passed
@Icebluewolf Icebluewolf deleted the fix/paginator-default-buttons branch January 24, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants