Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement Attachmentflags and Attachment expiry attributes #2342

Merged
merged 7 commits into from
Jan 31, 2024
Merged

feat: Implement Attachmentflags and Attachment expiry attributes #2342

merged 7 commits into from
Jan 31, 2024

Conversation

NeloBlivion
Copy link
Member

Summary

  • Adds Attachment flags for clips, thumbnails and remix
  • Adds attributes for the new attachment URL expiry rules, the most relevant being Attachment.expires_at and Attachment.issued_at. Attachment.hm is included for completion.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@NeloBlivion NeloBlivion requested a review from a team as a code owner January 31, 2024 19:40
@pullapprove4 pullapprove4 bot requested a review from VincentRPS January 31, 2024 19:40
Dorukyum
Dorukyum requested changes Jan 31, 2024
View reviewed changes
discord/flags.py Outdated Show resolved Hide resolved
discord/flags.py Outdated Show resolved Hide resolved
@Dorukyum
Update discord/flags.py
a8fa977 
Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
@Dorukyum
Update discord/flags.py
3e2164e 
Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Dorukyum
Dorukyum requested changes Jan 31, 2024
View reviewed changes
discord/message.py Outdated Show resolved Hide resolved
@Dorukyum
Update discord/message.py
eacf38f 
Signed-off-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
@Dorukyum Dorukyum enabled auto-merge (squash) January 31, 2024 21:08
@Dorukyum Dorukyum merged commit 90f9023 into Pycord-Development:master Jan 31, 2024
29 checks passed
@NeloBlivion NeloBlivion mentioned this pull request Feb 3, 2024
Closed
OmLanke pushed a commit to OmLanke/pycord that referenced this pull request Feb 9, 2024
@NeloBlivion @OmLanke
feat: Implement Attachmentflags and Attachment expiry attributes (Pyc…
26bc1d7 
…ord-Development#2342)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorukyum Dorukyum Dorukyum approved these changes

@VincentRPS VincentRPS Awaiting requested review from VincentRPS

@CodeWithSwastik CodeWithSwastik Awaiting requested review from CodeWithSwastik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NeloBlivion @Dorukyum