Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type hint kwargs properly #2364

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

Dorukyum
Copy link
Member

@Dorukyum Dorukyum commented Feb 26, 2024

Summary

Fixes #2362.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Dorukyum Dorukyum added bug Something isn't working priority: high High Priority status: awaiting review Awaiting review from a maintainer labels Feb 26, 2024
@Dorukyum Dorukyum self-assigned this Feb 26, 2024
@Dorukyum Dorukyum requested a review from a team as a code owner February 26, 2024 18:10
Lulalaby
Lulalaby previously approved these changes Feb 26, 2024
@Dorukyum Dorukyum marked this pull request as draft February 26, 2024 18:11
@Dorukyum Dorukyum marked this pull request as ready for review February 26, 2024 18:13
@Dorukyum Dorukyum requested a review from a team as a code owner February 26, 2024 18:13
@Dorukyum Dorukyum enabled auto-merge (squash) February 26, 2024 18:13
@Lulalaby
Copy link
Member

@Dorukyum 2nd part of the issue said something about wrong docs. did u checked

@Dorukyum
Copy link
Member Author

@Lulalaby Yes, I've compared the docstring to that of commands.has_permissions, it seems accurate.

Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fuck it, we ball

@Dorukyum Dorukyum merged commit 52d7719 into Pycord-Development:master Feb 26, 2024
29 checks passed
@Dorukyum Dorukyum deleted the has-perms-type branch February 26, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: high High Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong Typehinting in ext/bridge/core.py
3 participants