Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement voice channel statuses #2368

Merged
merged 34 commits into from
Feb 28, 2024
Merged

feat: implement voice channel statuses #2368

merged 34 commits into from
Feb 28, 2024

Conversation

Icebluewolf
Copy link
Contributor

Summary

Implements voice channel statuses by adding the VoiceChannel.status property. Set the status with VoiceChannel.set_status(). And adds the on_voice_channel_status_update event. As of posting it does not implement the corresponding audit log actions.

Related DAPI docs PRs: #6398 and #6400

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Icebluewolf Icebluewolf requested a review from a team as a code owner February 28, 2024 02:43
@pullapprove4 pullapprove4 bot requested a review from plun1331 February 28, 2024 02:43
plun1331
plun1331 previously requested changes Feb 28, 2024
View reviewed changes
Copy link
Member

@plun1331 plun1331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chsngelog

Lulalaby
Lulalaby requested changes Feb 28, 2024
View reviewed changes
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

u have a typo in commit
amend :3

@plun1331 plun1331 dismissed their stale review February 28, 2024 02:46

womp womp

plun1331
plun1331 previously requested changes Feb 28, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
discord/channel.py Outdated Show resolved Hide resolved
discord/http.py Outdated Show resolved Hide resolved
discord/state.py Show resolved Hide resolved
Icebluewolf and others added 17 commits February 27, 2024 20:50
@Icebluewolf
chore: changelog
1060693
@Icebluewolf @plun1331
chore: Apply suggestions from code review
3207c21 
Co-authored-by: plun1331 <plun1331@gmail.com>
Signed-off-by: Icebluewolf <44532864+Icebluewolf@users.noreply.github.com>
@pre-commit-ci
style(pre-commit): auto fixes from pre-commit.com hooks
65c8ef2
@Lulalaby
fix: payload
5e4fe99
@pre-commit-ci
style(pre-commit): auto fixes from pre-commit.com hooks
a09470d
@Lulalaby
feat: raw_voice_channel_status_update
3d88511
@pre-commit-ci
style(pre-commit): auto fixes from pre-commit.com hooks
35ad8c8
@Lulalaby
fuck me
fa87ec0
@Lulalaby
Merge branch 'master' of github.com:Icebluewolf/pycord into pr/2368
d43119f
@Lulalaby
REEEEEEE
f3a4bf9
@Icebluewolf @Lulalaby
feat: implement coice channel statuses
2f438e2
@Icebluewolf @Lulalaby
chore: changelog
786d861
@pre-commit-ci @Lulalaby
style(pre-commit): auto fixes from pre-commit.com hooks
b5ba2b9
@Icebluewolf @plun1331 @Lulalaby
chore: Apply suggestions from code review
549fa56 
Co-authored-by: plun1331 <plun1331@gmail.com>
Signed-off-by: Icebluewolf <44532864+Icebluewolf@users.noreply.github.com>
@pre-commit-ci @Lulalaby
style(pre-commit): auto fixes from pre-commit.com hooks
8d86cb6
@Lulalaby
fix: payload
fa7894f
@pre-commit-ci @Lulalaby
style(pre-commit): auto fixes from pre-commit.com hooks
7972c8e
@Lulalaby Lulalaby requested a review from plun1331 February 28, 2024 04:00
Lulalaby
Lulalaby previously approved these changes Feb 28, 2024
View reviewed changes
@Icebluewolf
Copy link
Contributor Author

I fixed the arg names and tested all of the changes Plun and Lala made. 👍

@Dorukyum Dorukyum enabled auto-merge (squash) February 28, 2024 15:37
Dorukyum
Dorukyum approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@Dorukyum Dorukyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Lulalaby Lulalaby disabled auto-merge February 28, 2024 15:39
@Lulalaby
Copy link
Member

We need the audit log events in another pull request to complete the voice channel status feature implementation

@Lulalaby Lulalaby merged commit 76a3e4c into Pycord-Development:master Feb 28, 2024
29 checks passed
@Lulalaby Lulalaby mentioned this pull request Feb 28, 2024
Closed
@Lulalaby Lulalaby linked an issue Feb 28, 2024 that may be closed by this pull request
Add receiving and setting the status for the voice channel #2325
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorukyum Dorukyum Dorukyum approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

@plun1331 plun1331 Awaiting requested review from plun1331

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add receiving and setting the status for the voice channel
4 participants
@Icebluewolf @Lulalaby @plun1331 @Dorukyum