-
-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support bulk banning in guilds #2421
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly make a new method instead (guild.bulk_ban) since they're different endpoints, and similar stuff is split as well (e.g. fetch_member vs fetch_members)
Co-authored-by: plun1331 <plun1331@gmail.com> Signed-off-by: UK <41271523+NeloBlivion@users.noreply.github.com>
I did consider this initially, but after mulling it over I figured it made more sense to compare to |
My main issue is we end up having multiple different return types, which isn't a massive problem but might be confusing as some people might pass a list and not expect it to give |
I agree with plun, a new method should suffice. |
Upon implementing it myself I agree with doru, a seperate method is needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert changes and introduce bulk banning as new method bulk_ban.
Also we should finally remove delete message days
Signed-off-by: UK <41271523+NeloBlivion@users.noreply.github.com>
With this, 2.6 is officially breaking so please include the relevant warnings in any announcements |
Before we merge it, @Dorukyum, do you agree on removing the obsolete parameter completely in this PR? |
It's fine. A seperate pr for each change would obviously be better, but the changes here are relevant enough I guess. |
Summary
Guild.ban
now accepts up to 200 membersCurrently, this returns two lists:
Alternatively, we could have a new
GuildBulkBan
object with attributesbanned
andfailed
Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.