Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Raise WebSocketClosure on protocol level errors #2435

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

Jegarde
Copy link
Contributor

@Jegarde Jegarde commented Apr 24, 2024

Summary

My bot crashed from the exception aiohttp.http_websocket.WebSocketError: Received fragmented control frame. Did some research and the exact same crash was reported in this discord.py discussion. This pull request applies the same patch made for this issue in this discord.py commit.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nvm, please merge the else block with the one after it since it will do the same then

@Lulalaby Lulalaby enabled auto-merge (squash) April 26, 2024 12:30
@Lulalaby Lulalaby merged commit 0536899 into Pycord-Development:master Apr 26, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants