fix: 🐛 Fix Interaction.channel incorrectly set
#2658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paillat-dev
force-pushed
the
fix-interaction-channel-perms
branch
from
d9af48f to
0fcf795
Compare
Paillat-dev
force-pushed
the
fix-interaction-channel-perms
branch
from
8683daa to
96a3141
Compare
Paillat-dev
changed the title
Interaction.channel incorrectly setInteraction.channel incorrectly set
|
Removing |
|
Ok |
JustaSqu1d
suggested changes
Dec 12, 2024
Signed-off-by: Paillat <me@paillat.dev>
JustaSqu1d
suggested changes
Dec 17, 2024
Lulalaby
approved these changes
Dec 23, 2024
Dorukyum
reviewed
Dec 26, 2024
| @@ -306,12 +318,12 @@ def is_component(self) -> bool: | |||
| return self.type == InteractionType.component | |||
|
|
|||
| @utils.cached_slot_property("_cs_channel") | |||
| @utils.deprecated("Interaction.channel", "2.7", stacklevel=4) | |||
There was a problem hiding this comment.
Nelo said I should deprecate instead of remove since I removed it in the beginning.
It makes no sense to have it imo, it provides at best the same as .channel and at worst just partials that serve no purpose that .channel would not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
InteractionPayload["channel"]is partial, thus, when creating a GuildChannel object from it, some attributes were missing/incorrectly set. With this pr,InteractionPayload["channel"]is used only in the following cases:In all other cases, it uses the full channel object from the cache.
Information
fixes:
permissions_forreturning wrong permissions #2281examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.