feat: ✨ Allow for functools.partial and functions returning an awaitable as autocomplete
#2669
+115
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paillat-dev
changed the title
functools.partials and such as autocompletefunctools.partials and such as autocomplete
|
@DefiDebauchery Would you mind testing this pr with your usecase and |
Paillat-dev
commented
Dec 12, 2024
Yes, this did work on my side, thank you! While I also like the solution offered in #2668 (comment), I do think partials make sense in many contexts, and it would be great to have support for those who need something quick. |
Paillat-dev
force-pushed
the
partial-autocomplete
branch
from
3382447 to
142215d
Compare
Paillat-dev
force-pushed
the
partial-autocomplete
branch
from
142215d to
53036a4
Compare
Paillat-dev
changed the title
functools.partials and such as autocompletefunctools.partials functions returning an awaitable as autocomplete
Paillat-dev
changed the title
functools.partials functions returning an awaitable as autocompletefunctools.partial functions returning an awaitable as autocomplete
Paillat-dev
changed the title
functools.partial functions returning an awaitable as autocompletefunctools.partial and functions returning an awaitable as autocomplete
Paillat-dev
commented
Dec 13, 2024
|
Oh shoot checks failing... This is why we should be using |
DA-344
reviewed
Dec 14, 2024
Paillat-dev
force-pushed
the
partial-autocomplete
branch
from
b46e70e to
c2b4011
Compare
DA-344
reviewed
Dec 14, 2024
DA-344
suggested changes
Dec 14, 2024
Paillat-dev
force-pushed
the
partial-autocomplete
branch
2 times, most recently
from
9c80445 to
6ec28e1
Compare
Paillat-dev
force-pushed
the
partial-autocomplete
branch
from
efeb190 to
1dddf13
Compare
JustaSqu1d
suggested changes
Dec 17, 2024
Dorukyum
requested changes
Dec 26, 2024
JustaSqu1d
suggested changes
Dec 27, 2024
Comment on lines
+39
to
+40
| - Added the ability to use functions with any number of optional arguments, and | ||
| functions returning an awaitable as `Option.autocomplete`. |
There was a problem hiding this comment.
Suggested change
| - Added the ability to use functions with any number of optional arguments, and | |
| functions returning an awaitable as `Option.autocomplete`. | |
| - Added the ability to use functions with any number of optional arguments and | |
| functions returning an awaitable as `Option.autocomplete`. |
Redundant comma
There was a problem hiding this comment.
Can this not be merged with the current autocomplete example?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allows usage of functions with any number of optional parameters as autocomplete. This allows by extent the usage of partials and similar as autocomplete.
Fixes #2668
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.