Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 👽 Update base max filesize to 10 Mb #2671

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

Paillat-dev
Copy link
Contributor

@Paillat-dev Paillat-dev commented Dec 17, 2024

Summary

https://discord.com/developers/docs/change-log#default-file-upload-limit-change

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • [-] If code changes were made then they have been tested.
    • [-] I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Paillat-dev Paillat-dev requested a review from a team as a code owner December 17, 2024 18:09
@pullapprove4 pullapprove4 bot requested a review from VincentRPS December 17, 2024 18:09
@Paillat-dev Paillat-dev changed the title 👽 Update base max filesize to 10 Mb fix: 👽 Update base max filesize to 10 Mb Dec 17, 2024
@Paillat-dev Paillat-dev changed the title fix: 👽 Update base max filesize to 10 Mb chore: 👽 Update base max filesize to 10 Mb Dec 17, 2024
@Paillat-dev
Copy link
Contributor Author

Does this need changelog ?

@JustaSqu1d
Copy link
Member

Does this need changelog ?

yes

@Lulalaby Lulalaby merged commit 8dd4b4f into Pycord-Development:master Dec 18, 2024
24 of 25 checks passed
@Paillat-dev Paillat-dev deleted the update-file-limits branch December 18, 2024 16:55
@@ -77,6 +77,8 @@ These changes are available on the `master` branch, but have not yet been releas
- Replaced audioop (deprecated module) implementation of `PCMVolumeTransformer.read`
method with a pure Python equivalent.
([#2176](https://github.com/Pycord-Development/pycord/pull/2176))
- Updated `Guild.filesize_limit` to 10 Mb instead of 25 Mb following Discord's API
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you use Mb instead of MB 😭

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ops

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants