Skip to content

Commit

Permalink
Merge pull request #1929 from jessedhillon/better-pshell-env-help
Browse files Browse the repository at this point in the history
populate pshell's env_help with docstring of values
  • Loading branch information
mmerickel committed Oct 15, 2015
2 parents 14a28d2 + 1c1c908 commit 7ec9b31
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CONTRIBUTORS.txt
Original file line number Diff line number Diff line change
Expand Up @@ -250,3 +250,5 @@ Contributors
- Karen Dalton, 2015/06/01

- Igor Stroh, 2015/06/10

- Jesse Dhillon, 2015/10/07
5 changes: 4 additions & 1 deletion pyramid/scripts/pshell.py
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,10 @@ def run(self, shell=None):
# remove any objects from default help that were overidden
for k, v in env.items():
if k not in orig_env or env[k] != orig_env[k]:
env_help[k] = v
if getattr(v, '__doc__', False):
env_help[k] = v.__doc__.replace("\n", " ")
else:
env_help[k] = v

# load the pshell section of the ini file
env.update(self.loaded_objects)
Expand Down
2 changes: 2 additions & 0 deletions pyramid/tests/test_scripts/test_pshell.py
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,7 @@ def test_command_setup(self):
def setup(env):
env['a'] = 1
env['root'] = 'root override'
env['none'] = None
self.config_factory.items = [('setup', setup)]
shell = dummy.DummyShell()
command.run(shell)
Expand All @@ -276,6 +277,7 @@ def setup(env):
'request':self.bootstrap.request,
'root_factory':self.bootstrap.root_factory,
'a':1,
'none': None,
})
self.assertTrue(self.bootstrap.closer.called)
self.assertTrue(shell.help)
Expand Down

0 comments on commit 7ec9b31

Please sign in to comment.