Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnencryptedCookieSessionFactoryConfig constructor works only with latin-1 secreet string #1246

Closed
zemlya25 opened this issue Feb 22, 2014 · 2 comments
Closed

UnencryptedCookieSessionFactoryConfig constructor works only with latin-1 secreet string #1246

zemlya25 opened this issue Feb 22, 2014 · 2 comments

Comments

@zemlya25
Copy link

When utf-8 secret string used it crashed with exception. Documentation does not contain this restriction. When we use bytes_(secret, 'utf-8') in pyramid/session.py everything works fine,
mmerickel added a commit that referenced this issue Feb 22, 2014
@mmerickel
test cases to reproduce #1246
69b613d
@mmerickel mmerickel mentioned this issue Feb 22, 2014
Closed
@mmerickel
Copy link
Member

Fixed in b2c2395. This will need to be fixed in webob for SignedCookieSessionFactory.

@mmerickel
Copy link
Member

Oops, added cf026e2 for bw-compat with secrets that were expecting the latin-1 default encoding.

@pyup-bot pyup-bot mentioned this issue Feb 26, 2017
Merged
@pyup-bot pyup-bot mentioned this issue Apr 30, 2017
Merged
@pyup-bot pyup-bot mentioned this issue Dec 12, 2017
Merged
@pyup-bot pyup-bot mentioned this issue Jun 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mmerickel @zemlya25