Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tox tests for python 2.6 fail due to WebTest requiring OrderedDict #2071

Closed
RaHus opened this issue Nov 3, 2015 · 5 comments
Closed

Tox tests for python 2.6 fail due to WebTest requiring OrderedDict #2071

RaHus opened this issue Nov 3, 2015 · 5 comments
Labels

Comments

@RaHus
Copy link
Contributor

RaHus commented Nov 3, 2015

OrderedDict was included in python 2.7 and WebTest requires it, so tests in python 2.6 fail with ImportError. We should include a backported version of OrderedDict in setup.tests_require when py_version is 2.6

@stevepiercy
Copy link
Member

@RaHus thanks for the explanation, and I agree. FWIW, I noticed TravisCI errors that recently cropped up on the branches master and 1.6-branch:
https://travis-ci.org/Pylons/pyramid/branches

Would you please submit a PR? You can use tox locally or watch TravisCI after submitting a PR to see results.

@RaHus
Copy link
Contributor Author

RaHus commented Nov 3, 2015

@stevepiercy Sure, i am on it

@RaHus
Copy link
Contributor Author

RaHus commented Nov 3, 2015

@stevepiercy Looks like its working now, should i touch CHANGES.txt also?

@stevepiercy
Copy link
Member

LGTM. I'd like one more core contributor to review.

Touching CHANGES.txt under "Bug Fixes" would be appropriate.

@RaHus
Copy link
Contributor Author

RaHus commented Nov 3, 2015

tseaver mentioned in the PR that this is actually a WebTest packaging bug and it should be fixed upstream.

@RaHus RaHus closed this as completed Nov 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants