-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tox tests for python 2.6 fail due to WebTest requiring OrderedDict #2071
Comments
@RaHus thanks for the explanation, and I agree. FWIW, I noticed TravisCI errors that recently cropped up on the branches master and 1.6-branch: Would you please submit a PR? You can use tox locally or watch TravisCI after submitting a PR to see results. |
@stevepiercy Sure, i am on it |
…6 since WebTest requires it. see Pylons#2071
@stevepiercy Looks like its working now, should i touch CHANGES.txt also? |
LGTM. I'd like one more core contributor to review. Touching CHANGES.txt under "Bug Fixes" would be appropriate. |
tseaver mentioned in the PR that this is actually a WebTest packaging bug and it should be fixed upstream. |
OrderedDict was included in python 2.7 and WebTest requires it, so tests in python 2.6 fail with ImportError. We should include a backported version of OrderedDict in setup.tests_require when py_version is 2.6
The text was updated successfully, but these errors were encountered: