use hmac.compare_digest if available #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmerickel
force-pushed
the
feature.string-timing-attacks
branch
from
582c391 to
18cf73a
Compare
mmerickel
force-pushed
the
feature.string-timing-attacks
branch
from
18cf73a to
716a20f
Compare
|
LGTM. |
|
Thank you for reviewing, Tres. |
mmerickel
added a commit
that referenced
this pull request
Nov 17, 2014
use hmac.compare_digest if available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stole most of this code from webob where I had previously added it. Improved the testing situation however.
Pretty annoying that this is
strings_differand notconstant_time_compare, considering it returnsFalsewhen strings are the same. Very counter-intuitive.