Supersedes: #2050 int conversion checks #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ktCookieHelper and CookieSession
|
Working on coverage... |
Previous tests did not actually test the code, other than by chance, which meant future changes could regress, which is bad.
|
Missing coverage for the timeout variable, previous tests did not adequately verify that timeout was actually doing what it was supposed to be doing. |
digitalresistor
force-pushed
the
feature/int_conversion_check
branch
from
fca5e09 to
203cf3a
Compare
mmerickel
added a commit
that referenced
this pull request
Nov 13, 2015
Supersedes: #2050 int conversion checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.