request.invoke exception view #2393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmerickel
force-pushed
the
feature.invoke_exception_view
branch
from
c3076fc to
bc09250
Compare
|
Much excitement =) 👍 from me. I just gave it a cursory glance though. |
|
Hey @tseaver I'm about to merge this, do you have any final objections? |
|
I guess I'm -0 on checking anything in that leaves the traceback-local binding around until GC kicks in. Not enough to block it (and we may be doing it elsewhere), but it still makes me uncomfortable. |
|
AFAICT based on #2393 (comment) there should be no need for GC here as there are no circular refs. The only possible issue in this api is if a user themselves calls |
mmerickel
added a commit
that referenced
this pull request
Mar 14, 2016
request.invoke exception view
mmerickel
added a commit
that referenced
this pull request
Mar 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new API for invoking exception views manually. This can be done for several reasons but the primary use-case is for error handling inside of tweens where it is desirable to utilize the registered exception views of the pyramid app to render errors instead of defining some other hook for rendering the error as is required when using wsgi middleware.