Changed 'host' and 'port' configuration to a new 'listen' style that … #2847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mfrlin please sign CONTRIBUTORS.txt Remember to pull from Pylons/pyramid first to get the latest version of CONTRIBUTORS.txt. Otherwise LGTM. |
|
@mfrlin would you add a change note, too? https://github.com/Pylons/pyramid/blob/master/CHANGES.txt |
|
Thank you! |
| @@ -27,8 +27,7 @@ sqlalchemy.url = sqlite:///%(here)s/tutorial.sqlite | |||
|
|
|||
| [server:main] | |||
| use = egg:waitress#main | |||
| host = 127.0.0.1 | |||
| port = 6543 | |||
| list = 127.0.0.1:6543 | |||
There was a problem hiding this comment.
uh.... list is not listen.
| @@ -16,8 +16,7 @@ sqlalchemy.url = sqlite:///%(here)s/tutorial.sqlite | |||
|
|
|||
| [server:main] | |||
| use = egg:waitress#main | |||
| host = 0.0.0.0 | |||
| port = 6543 | |||
| list = 0.0.0.0:6543 | |||
|
This should not have been merged without more carefully checking the PR for typo's and errors... |
|
There are a bunch of |
|
I've reverted this commit, follow the instructions in #2851 for updating this PR to be correct. Thanks. |
|
There is a new PR here #2853 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…is now supported by waitress server.
This should partly complete #2656