Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs scaffold to cookiecutter #2878

Closed

Conversation

stevepiercy
Copy link
Member

This PR includes work on:

  • complete wiki tutorial
  • wiki2 tutorial through authorization step (test and distribution not done yet)

Docs may be viewed starting at:
http://pyramid-stevepiercy.readthedocs.io/en/docs-scaffold-to-cookiecutter/tutorials/wiki/index.html

- unwrap
- fix grammar
- link should be generic to avoid release maintenance
- etc. to and so on
- no default templating systems, but use Chameleon
- add cookiecutter
- deprecate scaffold
- project src files are now in the properly named folder `pyramidtut`
- add glossary term `coverage`
- correct path to pyramidtut/
- update src files
- update src files
people download from PyPI.
removing 'pyramidtut-0.0' (and everything under it)

Note that this command creates a tarball in the ``dist`` subdirectory named ``pyramidtut-0.0.tar.gz``. You can send this file to your friends to show them your cool new application. They should be able to install it by pointing the ``easy_install`` command directly at it. Or you can upload it to `PyPI <https://pypi.python.org/pypi>`_ and share it with the rest of the world, where it can be downloaded via ``easy_install`` remotely like any other package people download from PyPI.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talk about pip here instead of easy_install. pip install pyramidtut-0.0.tar.gz should work fine.

Copy link
Member Author

@stevepiercy stevepiercy Dec 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.. versionadded:: 1.8

.. seealso:: See also :term:`scaffold`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a ref in here to somewhere in the docs containing a table of the 3 official cookiecutters?

Copy link
Member Author

@stevepiercy stevepiercy Dec 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in stevepiercy@e7b12f6 and it will be added in the updated scaffolding.rst when I get to it.


Test the models
===============
---------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did the sections get changed to --- from ===? The latter was the correct subsection.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change deferred to Style Guide

@@ -3,7 +3,7 @@

# Recommended naming convention used by Alembic, as various different database
# providers will autogenerate vastly different names making migrations more
# difficult. See: http://alembic.zzzcomputing.com/en/latest/naming.html
# difficult. See: http://alembic.readthedocs.org/en/latest/naming.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the correct URL. Perhaps the cookiecutter is incorrect.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -5,7 +5,7 @@

# import or define all models here to ensure they are attached to the
# Base.metadata prior to any initialization routines
from .mymodel import MyModel # noqa
from .mymodel import MyModel # flake8: noqa
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be 2 spaces here. Again probably the cookiecutter is out of date.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Success executing this command will end with a line to the console something
like this::
Success executing this command will end with a line to the console something like the following.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sentence should end with : instead of a period.


Only the highlighted line needs to be added.

.. note::

We are using the ``bcrypt`` package from PyPI to hash our passwords securely. There are other one-way hash algorithms for passwords if bcrypt is an issue on your system. Just make sure that it's an algorithm approved for storing passwords versus a generic one-way hash.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this another ref to the bcrypt link instead of just monospacing it. You already added the ref at the bottom of the file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rearranged this a bit. It flows better now, and only the first instance of bcrypt is hyperlinked.

@stevepiercy
Copy link
Member Author

stevepiercy commented Dec 23, 2016

I put the do-not-merge label on this PR because I tried to do too many extraneous things at once, and it should be closed eventually. New plan:

  • Update the cookiecutters per review comments.
  • Create a new branch from master, docs-cookiecutter-changes-only.
  • Only make changes that are necessary for the cookiecutters on docs-cookiecutter-changes-only.
  • Incorporate review comments in new branch.
  • Submit new PR, then close this PR.

@stevepiercy
Copy link
Member Author

Closing in favor of #2883 and #2881

@stevepiercy stevepiercy deleted the docs-scaffold-to-cookiecutter branch July 31, 2018 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants