Add support for Python 3.7 and 3.8 with allowed failure of 3.8 #3333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #3312. WIP DO NOT MERGE. |
|
The tests passed earlier, so I expect this to be OK to merge, pending this round of tests and peer review. Closes #3312. |
mmerickel
approved these changes
Aug 22, 2018
mmerickel
reviewed
Aug 22, 2018
docs/quick_tutorial/requirements.rst
Outdated
|
|
||
| * **venv**. We believe in virtual environments. For this tutorial, we use | ||
| Python 3.6's built-in solution :term:`venv`. For Python 2.7, you can install | ||
| Python 3.7's built-in solution :term:`venv`. For Python 2.7, you can install |
There was a problem hiding this comment.
This sentence could just say "Python 3's built-in solution"
mmerickel
reviewed
Aug 22, 2018
docs/quick_tour.rst
Outdated
| @@ -26,7 +26,7 @@ To save a little bit of typing and to be certain that we use the modules, | |||
| scripts, and packages installed in our virtual environment, we'll set an | |||
| environment variable, too. | |||
|
|
|||
| As an example, for Python 3.6+ on Linux: | |||
| As an example, for Python 3.7+ on Linux: | |||
There was a problem hiding this comment.
Similarly this could say just "for Python 3 on Linux"
|
Changes made, build should succeed in a few minutes. OK to merge after success? |
|
Sure
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.