preliminary fix for refactorings from 4d2602ce #727
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with the change from `__text__` to `text()` the code putting together the output used when `debug_routematch` is set was broken. it still uses `.__text__`. the same is true for the `pviews` script. however, simply changing things to use `.text()` breaks `test_views_command_single_view_route_with_route_predicates` and i'm not sure if the function used for a predicate there can be changed into a class, or if function predicates should still be supported...
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with the change from
__text__totext()the code putting together the output used whendebug_routematchis set was broken. it still uses.__text__. the same is true for thepviewsscript. however, simply changing things to use.text()breakstest_views_command_single_view_route_with_route_predicatesand i'm not sure if the function used for a predicate there can be changed into a class, or if function predicates should still be supported...