Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mail bcc recipients #7

Closed
mmerickel opened this issue Dec 10, 2011 · 3 comments
Closed

mail bcc recipients #7

mmerickel opened this issue Dec 10, 2011 · 3 comments

Comments

@mmerickel
Copy link
Member

According to mitchell` on #pyramid, there may be an issue sending mail to BCC recipients.

@marcinkuzminski
Copy link
Member

I can confirm there is a problem with BCC:

Tested on my app, I'd put CC and BCC (and different variations of it)

Mails get delivered to both cc or BCC but BCC is visible in the email header and can be read.

Here's the header of email I'd received

Bcc: marcin@python-works.com
Cc: marcin@python-blog.com
From: errors@****.com
Subject: test
To: marcin@****.com, marcin@*****.com

@mmerickel
Copy link
Member Author

Thanks for the confirmation.
On Jan 9, 2012 9:44 PM, "Marcin Kuźmiński" <
reply@reply.github.com>
wrote:

I can confirm there is a problem with BCC:

Tested on my app, I'd put CC and BCC (and different variations of it)

Mails get delivered to both cc or BCC but BCC is visible in the email
header and can be read.

Here's the header of email I'd received

Bcc: marcin@python-works.com
Cc: marcin@python-blog.com
From: errors@****.com
Subject: test
To: marcin@****.com, marcin@*****.com

Reply to this email directly or view it on GitHub:
#7 (comment)

@marcinkuzminski
Copy link
Member

The issue here is that the code adds bcc: header into the email, that is not correct. SMTP headers are really just for email clients, thus adding bcc header makes it visible in email clients.

The fix to this issue is to remove Bcc from ADDRESS_HEADERS_WHITELIST, and

        if self.bcc:
            response.base['Bcc'] = self.bcc

in get_response function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants