Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for issue #7 #10

Merged
merged 1 commit into from
Jan 22, 2012
+1 −16
Merged

fix for issue #7 #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions pyramid_mailer/message.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,6 @@ def get_response(self):
Body=self.body,
Html=self.html)

if self.bcc:
response.base['Bcc'] = self.bcc

if self.cc:
response.base['Cc'] = self.cc

Expand Down
2 changes: 1 addition & 1 deletion pyramid_mailer/response.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
from email.utils import parseaddr
from email.mime.base import MIMEBase

ADDRESS_HEADERS_WHITELIST = ['From', 'To', 'Delivered-To', 'Cc', 'Bcc']
ADDRESS_HEADERS_WHITELIST = ['From', 'To', 'Delivered-To', 'Cc']
DEFAULT_ENCODING = "utf-8"
VALUE_IS_EMAIL_ADDRESS = lambda v: '@' in v

Expand Down
12 changes: 0 additions & 12 deletions pyramid_mailer/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,18 +130,6 @@ def test_send_without_body(self):

mailer.send(msg)

def test_bcc(self):

from pyramid_mailer.message import Message

msg = Message(subject="testing",
recipients=["to@example.com"],
body="testing",
bcc=["tosomeoneelse@example.com"])

response = msg.get_response()
self.assert_("Bcc: tosomeoneelse@example.com" in str(response))

def test_cc(self):

from pyramid_mailer.message import Message
Expand Down