Fix for #14, skip empty headers

CHANGES.txt

@@ -1,3 +1,9 @@
+0.7 (Unreleased)
+----------------
+
+- Workaround a Python 3.2.0 bug in handling emails with empty
+  headers.
+
 0.6 (2012-03-20)
 ----------------
 

pyramid_mailer/message.py

@@ -139,10 +139,6 @@ def validate(self):
         if not (self.recipients or self.cc or self.bcc):
             raise InvalidMessage("No recipients have been added")
 
-        if (self.cc or self.bcc) and not self.recipients:
-            raise InvalidMessage("Must have at least one direct recipient "
-                                 "even if cc or bcc set")
-
         if not self.body and not self.html:
             raise InvalidMessage("No body has been set")
 

pyramid_mailer/response.py

@@ -343,6 +343,8 @@ def to_message(mail):
         if k.lower() in encoding.ADDR_HEADERS:
             if is_nonstr_iter(value): # not a string
                 value = ", ".join(value)
+        if value == '':
+            continue
         out[k] = value
 
     out.extract_payload(mail)

pyramid_mailer/tests.py

@@ -168,8 +168,22 @@ def test_cc_without_recipients(self):
                       body="testing",
                       cc=["tosomeoneelse@example.com"])
         mailer = Mailer()
-        from pyramid_mailer.exceptions import InvalidMessage
-        self.assertRaises(InvalidMessage, mailer.send, msg)
+        msgid = mailer.send(msg)
+        response = msg.get_response()
+
+        self.assertTrue("Cc: tosomeoneelse@example.com" in str(response))
+        self.assertTrue(msgid)
+
+    def test_cc_without_recipients_2(self):
+
+        from pyramid_mailer.message import Message
+
+        msg = Message(subject="testing",
+                      sender="sender@example.com",
+                      body="testing",
+                      cc=["tosomeoneelse@example.com"])
+        response = msg.get_response()
+        self.assertTrue("Cc: tosomeoneelse@example.com" in str(response))
 
     def test_bcc_without_recipients(self):
 
@@ -181,8 +195,11 @@ def test_bcc_without_recipients(self):
                       body="testing",
                       bcc=["tosomeoneelse@example.com"])
         mailer = Mailer()
-        from pyramid_mailer.exceptions import InvalidMessage
-        self.assertRaises(InvalidMessage, mailer.send, msg)
+        msgid = mailer.send(msg)
+        response = msg.get_response()
+
+        self.assertFalse("Bcc: tosomeoneelse@example.com" in str(response))
+        self.assertTrue(msgid)
 
     def test_attach(self):
 
@@ -959,6 +976,12 @@ def test_no_ctype_no_parts(self):
         result = self._callFUT(mail)
         self.assertEqual(result.__class__, MIMEPart)
 
+    def test_empty_header(self):
+        mail = self._makeBase()
+        mail['To'] = ''
+        result = self._callFUT(mail)
+        self.assertFalse('To' in result)
+
 class TestMIMEPart(unittest.TestCase):
     def _makeOne(self, type, **params):
         from pyramid_mailer.response import MIMEPart