Do not supply charset parameter to set_payload. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It eventually instructs email.message.Message to dismiss the charset specified in Content-Type and furthermore recode the payload charset according to the global mappings predefined in the module, which is totally unwanted.
|
I'll need to swap this package back into my head to feel satisfied that this is a good change. That may take a bit. |
|
Later I noticed that the change like the following (see the latest two of https://github.com/moriyoshi/pyramid_mailer/commits/moriyoshi/give-charset-object-instead-of-name ) should make much more sense, but this change would be more acceptable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying the charset to email.message.Message eventually instructs it to dismiss the charset specified in Content-Type and furthermore recode the payload charset according to the global mappings predefined in the module, which is totally unwanted.