Coverting debug and port values in Mailer.from_settings #67 #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a test that passes in a string to demonstrate the problem you're fixing? |
|
Of course @mmerickel |
|
For example you could simply update the current test to use a string, as the assertion down below is ensuring it is an int value of 1. https://github.com/Pylons/pyramid_mailer/blob/master/pyramid_mailer/tests/test_mailer.py#L190 |
|
@marcinkuzminski done 👍 |
|
Looks good, can you please sign the contributors.txt file? |
mmerickel
added a commit
that referenced
this pull request
May 21, 2015
Coverting debug and port values in Mailer.from_settings #67
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In tests, This problem don't appear...