-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support / require pyramid >= 2.0 #308
Open
tseaver
wants to merge
15
commits into
master
Choose a base branch
from
tseaver-pyramid2-compat
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tseaver
force-pushed
the
tseaver-pyramid2-compat
branch
2 times, most recently
from
August 29, 2024 22:56
34c8915
to
7784638
Compare
Until we figure out the replacement.
Pyramid 2.0 no longer provides that API.
Add test coverage.
tseaver
force-pushed
the
tseaver-pyramid2-compat
branch
from
August 30, 2024 15:43
7784638
to
8f8131c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds atop changes in #307. I will rebase this PR once that one merges.Rebased after merge of #307.Coverage is at 100%, and all tests pass for
py38
throughpy312
, except the ones forsubstanced.scaffold
, which I just turned off. To appease our new insect overlords, we would likely need to make the scaffold into a cookiecutter template project.I'm disabling a bunch of deprecation warning spew, mostly from
chameleon
(it interacts with Python AST internals in ways that will break under Python 3.14) andhypatia
(maybe similar? I haven't checked).