Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set clear_untrusted_proxy_headers parameter to True by default #370

Merged
merged 3 commits into from
Mar 19, 2022
Merged

Set clear_untrusted_proxy_headers parameter to True by default #370

merged 3 commits into from
Mar 19, 2022

Conversation

Yourun-proger
Copy link
Contributor

@Yourun-proger Yourun-proger commented Mar 16, 2022 •
edited
Loading

Refs to #330
I just changed the default value and removed the warning. I also removed the _bool_maker, because it was no longer needed. An update has been made in the documentation.

@digitalresistor
Copy link
Member

This change is not making it into 2.1.1, if you could update it to 2.1.2 that would be great.

@digitalresistor
Copy link
Member

Please run:

tox -e format

to make sure the code matches the coding style required. You will also want to run tests locally and remove/fix any tests that now fail due to the removal.

@Yourun-proger
Copy link
Contributor Author

Oh! Forgive me for this major omission...
Now I refactored through tox and changed version. I would like to ask: is this test, on which CI fails, really needed now? After all, this test just checked that the deprecation message appears. Now it has nothing to check. Should it be removed?

@digitalresistor
Copy link
Member

Yes, it can be removed if the test is no longer relevant. Please be aware that #330 is also about cleaning up other warnings, of which there are far more than just the proxy one that you are cleaning up here. I am okay with accepting this small change, but it does not fix #330.

digitalresistor
digitalresistor requested changes Mar 17, 2022
View reviewed changes
docs/arguments.rst Outdated Show resolved Hide resolved
@Yourun-proger
Copy link
Contributor Author

Now all must be OK

@digitalresistor digitalresistor merged commit 603d2c1 into Pylons:master Mar 19, 2022
@digitalresistor
Copy link
Member

Thank you!

digitalresistor added a commit that referenced this pull request May 30, 2022
@digitalresistor
Revert "Merge pull request #370 from Yourun-proger/del_warnings"
2784628 
This reverts commit 603d2c1, reversing
changes made to 9e0b8c8.
digitalresistor added a commit that referenced this pull request May 30, 2022
@digitalresistor
Revert "Revert "Merge pull request #370 from Yourun-proger/del_warnin…
ca95fa2 
…gs""

This reverts commit 2784628.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digitalresistor digitalresistor digitalresistor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yourun-proger @digitalresistor