-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes in behavior for DISPATCHES flowsheet between Pyomo 6.5 and 6.6 #2876
Comments
@lbianchi-lbl Something that might help is to check the state of the model after initialization to see if there is any difference before calling the GDP solver; this might help determine if it is something to do with the GDP solver or the model itself. |
I am having problems reproducing these test failures, using:
running
gives
|
SummaryI am observing what may the same issue. Symptoms
Investigation
System Information
Steps to ReproduceGridPath with Pyomo v6.5.0 (tests pass)
GridPath with Pyomo v6.6.0 (some tests fail due to changes in the objective function value)
|
@anamileva, I cannot reproduce your case. Running your first example under RHEL7 / Python 3.9, I get:
I am going to close this issue, as the originally reported problem was resolved downstream in DISPATCHES (and we should have closed this at the same time). @anamileva, please feel free to open a new issue for your observed behavior and we can continue to work through things there. When you do, please:
|
@jsiirola, thank you. Indeed I should have mentioned I did observe what seemed like ordering differences in the LP files. I will try to fix the RHEL7 problem and/or send you an easy-to-work-with example when I open a new issue. |
Summary
Symptoms
Investigation
pytest -v -x --pyargs dispatches -k test_charge_usc_powerplant
(exact details described below)Results
RuntimeError
raised bySymbolMap.addSymbol()
(outcome C)assert False == True
) (outcome D)Steps to reproduce the issue
Step 1: prepare the environment
Step 2: generate list of commit SHAs to be tested in oldest-first order
Step 3: run for every Pyomo commit to be tested (
git bisect
-style){}
is expanded to the full SHA of the commit (the command is run serially throughxargs
to serve as a poor impression ofgit bisect run
)git show f492dd8 -- pyomo/contrib/fbbt/fbbt.py | git apply -
is needed between 687f4a2 and edf4ccc, but practically running it outside that range doesn't seem to make a difference (thegit apply
command will fail without apparent side effects)bash -c 'git checkout {} ; git show f492dd8 -- pyomo/contrib/fbbt/fbbt.py | git apply - ; pip uninstall --yes pyomo ; pip install . ; pytest -v -x --pyargs dispatches -k test_charge_usc_powerplant > ../logs/{}.log ; git reset --hard {}'
Error Message
Outcome A
Outcome B
Outcome C
Outcome D
Information on your system
Pyomo version:
Python version: 3.8
Operating system: Ubuntu 20.04.5 (but also appears on
windows-2019
runners in CI)How Pyomo was installed (PyPI, conda, source): source (see above)
Solver (if applicable): GDPopt
Additional information
"CC-ing" folks who have actual knowledge of the flowsheet, and/or have been made aware of this issue:
Client packages
idaes-pse
: 2.0.0 (PyPI)dispatches
:gmlc-dispatches/dispatches@03b936a7c0999c2e91f542094557c708532ba7e6
Test file
https://github.com/gmlc-dispatches/dispatches/blob/03b936a7c0999c2e91f542094557c708532ba7e6/dispatches/case_studies/fossil_case/ultra_supercritical_plant/storage/tests/test_charge_usc_powerplant.py
The text was updated successfully, but these errors were encountered: