Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in FBBT (GeneralExpression) #2848

Merged
merged 2 commits into from
May 26, 2023

Conversation

jsiirola
Copy link
Member

Fixes #2846

Summary/Motivation:

This fixes a typo in FBBT, and adds a test to exercise the code.

Changes proposed in this PR:

  • Fix typo, add test

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Copy link
Contributor

@michaelbynum michaelbynum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d8cbd46) 87.44% compared to head (c2fe429) 87.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2848   +/-   ##
=======================================
  Coverage   87.44%   87.44%           
=======================================
  Files         771      771           
  Lines       89539    89539           
=======================================
+ Hits        78294    78296    +2     
+ Misses      11245    11243    -2     
Flag Coverage Δ
linux 84.50% <100.00%> (+<0.01%) ⬆️
osx 74.54% <100.00%> (+<0.01%) ⬆️
other 84.68% <100.00%> (+<0.01%) ⬆️
win 82.08% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyomo/contrib/fbbt/fbbt.py 96.96% <100.00%> (+1.06%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnboundLocalError in FBBT _prop_bnds_leaf_to_root_GeneralExpression()
2 participants