-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize and Fix Uncertain Parameter Bounds Evaluation for PyROS FactorModelSet
#2620
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable.
…yomo into fix-factor-model-bounds
Codecov ReportBase: 87.00% // Head: 87.07% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2620 +/- ##
==========================================
+ Coverage 87.00% 87.07% +0.06%
==========================================
Files 754 754
Lines 83954 84672 +718
==========================================
+ Hits 73047 73727 +680
- Misses 10907 10945 +38
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Summary/Motivation:
Generalize the PyROS
FactorModelSet
to allow for cases in which thepsi_mat
attributecontains nonnegative entries.
Additionally, we target the following issues with the PyROS
FactorModelSet.parameter_bounds
method:Changes proposed in this PR:
FactorModelSet
to allow cases in whichpsi_mat
contains negative entries (and update the documentation accordingly)FactorModelSet.parameter_bounds
UncertaintySet
instancesparameter_bounds
gives results which are consistent with bounding LP solutions.Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: