Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FBBT: Add tolerances to tests #2675

Merged
merged 2 commits into from
Dec 20, 2022
Merged

FBBT: Add tolerances to tests #2675

merged 2 commits into from
Dec 20, 2022

Conversation

blnicho
Copy link
Member

@blnicho blnicho commented Dec 20, 2022

Summary/Motivation:

Following the latest NumPy release a couple FBBT tests started failing. I added a machine precision tolerance to the failing tests following #2445 as an example.

Changes proposed in this PR:

  • Add machine precision tolerance to a couple fbbt tests

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Copy link
Contributor

@michaelbynum michaelbynum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @blnicho!

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Base: 87.06% // Head: 87.05% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (f4c1120) compared to base (3119236).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2675      +/-   ##
==========================================
- Coverage   87.06%   87.05%   -0.01%     
==========================================
  Files         757      757              
  Lines       84449    84449              
==========================================
- Hits        73525    73517       -8     
- Misses      10924    10932       +8     
Flag Coverage Δ
linux 84.50% <ø> (-0.01%) ⬇️
osx ?
other 84.68% <ø> (+<0.01%) ⬆️
win 81.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyomo/contrib/mindtpy/iterate.py 79.54% <0.00%> (-1.82%) ⬇️
pyomo/solvers/plugins/solvers/ASL.py 90.00% <0.00%> (-1.43%) ⬇️
pyomo/common/download.py 92.17% <0.00%> (-0.44%) ⬇️
pyomo/core/expr/visitor.py 93.24% <0.00%> (-0.16%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jsiirola jsiirola merged commit ed5e026 into Pyomo:main Dec 20, 2022
@blnicho blnicho deleted the fix-fbbt-tests branch December 20, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants