-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch default NL writer to nlv2 #2676
Conversation
We should add an issue to eventually remove the old nl writer. |
The use of as_numeric() was unnecessary, and int he case of relational expressions, deprecated behavior.
Codecov ReportBase: 87.04% // Head: 87.09% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2676 +/- ##
==========================================
+ Coverage 87.04% 87.09% +0.05%
==========================================
Files 757 757
Lines 84596 84898 +302
==========================================
+ Hits 73638 73945 +307
+ Misses 10958 10953 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good, @jsiirola . I didn't even see any typos.
Fixes # .
Summary/Motivation:
This switches the default NL writer to the new "NLv2" writer.
Changes proposed in this PR:
pyomo.mpec.complementarity
to suppress deprecation warningsfile_determinism
flag int eh NLv1 writerinf
/-inf
bounds on Constraints/Vars toNone
\r\n
line terminatorsLegal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: